Skip to content

Dashboard: Fix login infinite loop on certain wallets #6825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Dashboard: Fix login infinite loop on certain wallets #6825

merged 1 commit into from
Apr 23, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 23, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR enhances the EnsureValidConnectedWalletLoginClient component by improving the validation check for the connected wallet address, ensuring that both addresses are compared in a checksum format for better accuracy.

Detailed summary

  • Added import for checksumAddress from thirdweb/utils.
  • Updated the address comparison logic to use checksumAddress for both connectedAddress and props.loggedInAddress.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – wallet-ui April 23, 2025 11:04 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 23, 2025 11:04 Inactive
@vercel
Copy link

vercel bot commented Apr 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 11:21am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 23, 2025 11:21am
login ⬜️ Skipped (Inspect) Apr 23, 2025 11:21am
thirdweb_playground ⬜️ Skipped (Inspect) Apr 23, 2025 11:21am
wallet-ui ⬜️ Skipped (Inspect) Apr 23, 2025 11:21am

@vercel vercel bot temporarily deployed to Preview – login April 23, 2025 11:04 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 23, 2025 11:04 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a9adbaf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank marked this pull request as ready for review April 23, 2025 11:04
@MananTank MananTank requested review from a team as code owners April 23, 2025 11:04
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 23, 2025
@MananTank Graphite App
Copy link
Member Author

MananTank commented Apr 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Apr 23, 2025 — with Graphite App
@codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (dc2e514) to head (2890f48).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6825   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files         896      896           
  Lines       56952    56952           
  Branches     3944     3944           
=======================================
  Hits        31431    31431           
  Misses      25425    25425           
  Partials       96       96
Flag Coverage Δ
packages 55.18% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MananTank MananTank changed the title Dashboard: Fix login infinite loop Dashboard: Fix login infinite loop on certain wallets Apr 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.92 KB (-0.01% 🔽) 1.1 s (-0.01% 🔽) 235 ms (+123.46% 🔺) 1.3 s
thirdweb (cjs) 143.74 KB (0%) 2.9 s (0%) 401 ms (+41.11% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 63 ms (+586.26% 🔺) 177 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 33 ms (+1068.35% 🔺) 43 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 100 ms (+443.93% 🔺) 487 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 23, 2025

Merge activity

@MananTank
Dashboard: Fix login infinite loop on certain wallets (#6825)
a9adbaf 
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the `EnsureValidConnectedWalletLoginClient` component to ensure that wallet addresses are compared in a case-insensitive manner by using the `checksumAddress` function.

### Detailed summary
- Added import of `checksumAddress` from `thirdweb/utils`.
- Updated the conditional check to compare `connectedAddress` and `props.loggedInAddress` using `checksumAddress` for both values.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-23-dashboard_fix_login_infinite_loop branch from 2890f48 to a9adbaf Compare April 23, 2025 11:14
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 23, 2025 11:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 23, 2025 11:14 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 23, 2025 11:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 23, 2025 11:14 Inactive
@jnsdls jnsdls merged commit ec194a6 into main Apr 23, 2025
10 checks passed
@jnsdls jnsdls deleted the 04-23-dashboard_fix_login_infinite_loop branch April 23, 2025 11:29
@graphite-app graphite-app bot removed the hotfix This pull request should be prioritized in the merge queue. label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xFirekeeper 0xFirekeeper 0xFirekeeper approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MananTank @0xFirekeeper @jnsdls